[ 
https://issues.apache.org/jira/browse/HADOOP-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated HADOOP-3417:
--------------------------------------------

    Attachment: patch-3417.txt

Here is a patch doing the following:

1. Removes the static configuration variable, commandLineConfig from JobClient.
2. Moves the cli parsing from JobShell to GenericOptionsParser. Thus removes 
the class org.apache.hadoop.mapred.JobShell .
3. Refactors TestJobShell as TestCommandLineJobSubmission, which tests the 
command line options -files, -libjars
4. testshell.ExternalMapReduce class is modified to implement 
org.apache.hadoop.util.Tool, sothat it can be run from ToolRunner.

> JobClient should not have a static configuration for cli parsing
> ----------------------------------------------------------------
>
>                 Key: HADOOP-3417
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3417
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.17.0
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3417.txt
>
>
> HADOOP-1622 introduced a static configuration variable into JobClient that 
> prevents it from being used by multiple threads. Furthermore, the cli 
> processing that HADOOP-1622 added should be in the GenericOptionParser 
> instead of JobShell so that all of the implementations of Tool can use them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to