[
https://issues.apache.org/jira/browse/HADOOP-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601483#action_12601483
]
Hadoop QA commented on HADOOP-3475:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12383158/3475-1.patch
against trunk revision 661918.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2530/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2530/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2530/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2530/console
This message is automatically generated.
> MapOutputBuffer allocates 4x as much space to record capacity as intended
> -------------------------------------------------------------------------
>
> Key: HADOOP-3475
> URL: https://issues.apache.org/jira/browse/HADOOP-3475
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.18.0
>
> Attachments: 3475-1.patch
>
>
> When setting up its accounting tables, MapTask.MapOutputBuffer calculates the
> size of each of its buffers as:
> {noformat}
> Where #total_bytes is $io.sort.mb * 2^20 and #accounting_bytes is
> $io.sort.record.percent * #total_bytes
> kvbuffer: #total_bytes - #accounting_bytes
> kvoffsets: 1/4 of #accounting_bytes
> kvindices: 3/4 of #accounting_bytes
> {noformat}
> kvoffsets and kvindices are ints, not bytes; the size of both arrays is
> incorrectly calculated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
