[ 
https://issues.apache.org/jira/browse/HADOOP-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601811#action_12601811
 ] 

Hadoop QA commented on HADOOP-2909:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12383264/idleConn.patch
  against trunk revision 662569.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2540/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2540/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2540/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2540/console

This message is automatically generated.

> Improve IPC idle connection management
> --------------------------------------
>
>                 Key: HADOOP-2909
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2909
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.16.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.18.0
>
>         Attachments: idleConn.patch
>
>
> IPC server determines if a connection is idle or not by checking if the 
> connection does not have any IO activity for a predefined max idle time. An 
> idle connection will be closed even if the connection still has outstanding 
> requests or replies. This causes RPC failures when a server becomes slow or 
> if a request takes a long time to be served. In jira, I'd like to propose the 
> following changes to IPC idle management:
> 1. Add data structures to the IPC server that keep track of outstanding 
> requests.
> 2. IPC server does not close a connection that has outstanding 
> requests/replies even when it has no IO activities for a while.
> 3. The default client-side max idle time should be in several minutes not 1 
> second. 
> 4. The server-side max idle time should be greater than the client-side max 
> idle time, for example, twice of the client-side max idle time. So server 
> mainly deals with clients that are crashed without closing 
> its connections. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to