[ 
https://issues.apache.org/jira/browse/HADOOP-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602104#action_12602104
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3187:
------------------------------------------------

Two minor comments to the new patch.  Otherwise, everything looks good to me.

- We don't need readLongWritable(DataInputStream in), just call in.readLong().

- In unprotectedClearQuota, I think "if (targetNode.getQuota() >= 0) {" should 
be "if (targetNode instanceof INodeDirectoryWithQuota) {".  The assert followed 
can be removed.



> Quotas for name space management
> --------------------------------
>
>                 Key: HADOOP-3187
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3187
>             Project: Hadoop Core
>          Issue Type: New Feature
>            Reporter: Robert Chansler
>            Assignee: Hairong Kuang
>             Fix For: 0.18.0
>
>         Attachments: quota.patch, quota1.patch, quota2.patch, 
> QuotasDesign.pdf, QuotasDesign1.pdf
>
>
> Create a quota mechanism for name space management. 
> Quota set at a directory by super user restricts that number of names in and 
> below that directory.
> Quota tested by create() and rename().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to