[ 
https://issues.apache.org/jira/browse/HADOOP-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602181#action_12602181
 ] 

dhruba borthakur commented on HADOOP-3452:
------------------------------------------

+1 code looks good. Is there a reason why we match the string "is CORRUPT" and 
not just "CORRUPT"? If we are doing this on purpose, then the comment in the 
DFSck.java should mention that "is CORRUPT" is the precise string that is being 
used.

> fsck exit code would be better if non-zero when FS corrupt
> ----------------------------------------------------------
>
>                 Key: HADOOP-3452
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3452
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Pete Wyckoff
>            Priority: Minor
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3452-1.patch, HADOOP-3452-2.patch
>
>
> fsck exit code would be better if behaved like other sys admin tools and exit 
> code indicated healthy/corrupt or other  errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to