[
https://issues.apache.org/jira/browse/HADOOP-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603199#action_12603199
]
Lohit Vijayarenu commented on HADOOP-3489:
------------------------------------------
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or
modified tests.
[exec] Please justify why no tests are needed for this
patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of
javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
> NPE in SafeModeMonitor
> ----------------------
>
> Key: HADOOP-3489
> URL: https://issues.apache.org/jira/browse/HADOOP-3489
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3489-1.patch
>
>
> If dfsadmin issues -safemode leave command when name-node is in the extended
> period of safe mode the SafeModeMonitor throws the following exception:
> {code}
> Exception in thread "[EMAIL PROTECTED]" java.lang.NullPointerException
> at
> org.apache.hadoop.dfs.FSNamesystem$SafeModeMonitor.run(FSNamesystem.java:3914)
> at java.lang.Thread.run(Thread.java:619)
> {code}
> The problem is that when SafeModeMonitor.run() wakes up it tries to check
> whether it canLeave() the safe mode, but the safe mode is off already,
> and therefore the "safemode" field is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
