[ 
https://issues.apache.org/jira/browse/HADOOP-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604061#action_12604061
 ] 

Lohit Vijayarenu commented on HADOOP-3528:
------------------------------------------

It passes all tests on LINUX machine. The patch does not have test case as this 
is fix for metrics. I tested manually to make sure the count matches.
[exec] 
[exec] -1 overall.  
[exec] 
[exec]     +1 @author.  The patch does not contain any @author tags.
[exec] 
[exec]     -1 tests included.  The patch doesn't appear to include any new or 
modified tests.
[exec]                         Please justify why no tests are needed for this 
patch.
[exec] 
[exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
[exec] 
[exec]     +1 javac.  The applied patch does not increase the total number of 
javac compiler warnings.
[exec] 
[exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
[exec] 
[exec]

> Metrics FilesCreated and files_deleted metrics do not match. 
> -------------------------------------------------------------
>
>                 Key: HADOOP-3528
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3528
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.0
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3528-1.patch
>
>
> This JIRA is to fix the files created vs files deleted count. Looks like 
> files created counts number of file created while files deleted counts number 
> of inodes deleted. For now, it would be good to fix files created to match 
> files deleted. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to