[
https://issues.apache.org/jira/browse/HADOOP-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604943#action_12604943
]
Hadoop QA commented on HADOOP-3556:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12383977/MD5Hash-ThreadLocal.patch
against trunk revision 667506.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2655/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2655/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2655/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2655/console
This message is automatically generated.
> Substitute the synchronized code in MD5Hash to avoid lock contention. Use
> ThreadLocal instead.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-3556
> URL: https://issues.apache.org/jira/browse/HADOOP-3556
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Iván de Prado
> Attachments: MD5Hash-ThreadLocal.patch
>
>
> Currently the MD5Hash class uses a singleton instance of the MessageDigester.
> The access to this instance is synchronized, so MD5Hash has performance
> problems when used from several Threads. I propose to substitute the
> singleton instance by a TheadLocal instances cache. I will provide a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
