[ 
https://issues.apache.org/jira/browse/HADOOP-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605448#action_12605448
 ] 

Konstantin Shvachko commented on HADOOP-3573:
---------------------------------------------

Part of this has already been done in HADOOP-2797. I see 4 more methods that 
need to be removed: 
{code}
FSImage.isConversionNeeded()
FSImage.corruptPreUpgradeStorage()
DataStorage.isConversionNeeded()
DataStorage.corruptPreUpgradeStorage()
{code}
New code should consider old (pre 0.13) images unformatted and generate a 
message saying that the storage is not formatted or contains old image layout.
I also think we should not create "corrupt" image directory any more.
If the image directory is not there pre 0.13 versions will not recognize the 
storage as formatted and fail.
Versions 0.14 - 0.17 will also fail because they require the (corrupt) image 
directory. 
The new code imo should ignore image directory if it exists, but should not 
create it if the image is upgraded to or formatted by 0.18.

> Remove code related to conversion of name-node and data-node storage 
> directories to the format introduced in hadoop 0.13
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3573
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3573
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>             Fix For: 0.19.0
>
>
> Hadoop 0.18 does not support direct HDFS upgrades from versions 0.13 or 
> earlier as stated in HADOOP-2797.
> A 2 step upgrade is required in this case first from 0.x <= 0.13 to one of 
> version 0.14 through 0.17 and then to 0.18.
> This implies that current hdfs does not need to support code related to 
> conversions of the old (pre 0.13) storage layout to the current one 
> introduced in 0.13 (see. HADOOP-702).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to