[ 
https://issues.apache.org/jira/browse/HADOOP-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605854#action_12605854
 ] 

Sriram Rao commented on HADOOP-3569:
------------------------------------

> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no tests are needed for this patch.

 The tests provided use a KFS emulation implementation via the localFS to test 
the APIs.  In that sense, the existing tests cover the read() API.  That said, 
testing of the code in fs/kfs/... requires a KFS deployment; this has always 
been  done elsewhere and I then submit the code for inclusion.


> KFS input stream read() returns 4 bytes instead of 1
> ----------------------------------------------------
>
>                 Key: HADOOP-3569
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3569
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.18.0
>            Reporter: Sriram Rao
>            Assignee: Sriram Rao
>            Priority: Minor
>             Fix For: 0.18.0
>
>         Attachments: patch.3569
>
>
> The call to KFSInputStream:read() returns 4 bytes; it should return 1 byte 
> (in conformance to java.io.inputstream read() signature).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to