[ 
https://issues.apache.org/jira/browse/HADOOP-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606236#action_12606236
 ] 

Hadoop QA commented on HADOOP-3320:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12384239/NullWriter.patch
  against trunk revision 669343.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2689/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2689/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2689/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2689/console

This message is automatically generated.

> NPE in NetworkTopology.getDistance()
> ------------------------------------
>
>                 Key: HADOOP-3320
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3320
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.14.0
>            Reporter: Konstantin Shvachko
>            Assignee: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: NullWriter.patch
>
>
> I am seeing the following exception:
> {code}
> 08/04/28 20:15:09 ERROR dfs.NNThroughputBenchmark: 
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.net.NetworkTopology.getDistance(NetworkTopology.java:443)
>       at 
> org.apache.hadoop.dfs.ReplicationTargetChooser.getPipeline(ReplicationTargetChooser.java:457)
>       at 
> org.apache.hadoop.dfs.ReplicationTargetChooser.chooseTarget(ReplicationTargetChooser.java:126)
>       at 
> org.apache.hadoop.dfs.ReplicationTargetChooser.chooseTarget(ReplicationTargetChooser.java:72)
>       at 
> org.apache.hadoop.dfs.FSNamesystem.getAdditionalBlock(FSNamesystem.java:1140)
>       at org.apache.hadoop.dfs.NameNode.addBlock(NameNode.java:300)
>       at 
> org.apache.hadoop.dfs.NNThroughputBenchmark$BlockReportStats.addBlocks(NNThroughputBenchmark.java:786)
>       at 
> org.apache.hadoop.dfs.NNThroughputBenchmark$BlockReportStats.generateInputs(NNThroughputBenchmark.java:775)
>       at 
> org.apache.hadoop.dfs.NNThroughputBenchmark$OperationStatsBase.benchmark(NNThroughputBenchmark.java:203)
>       at 
> org.apache.hadoop.dfs.NNThroughputBenchmark.runBenchmark(NNThroughputBenchmark.java:1035)
>       at 
> org.apache.hadoop.dfs.NNThroughputBenchmark.main(NNThroughputBenchmark.java:1053)
> {code}
> It looks like the problem is in NetworkTopology.chooseRandom(String, String), 
> which returns null in certain cases, but the value returned is never checked 
> for null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to