[
https://issues.apache.org/jira/browse/HADOOP-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606540#action_12606540
]
Hadoop QA commented on HADOOP-3599:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12384301/3599.patch
against trunk revision 669639.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2699/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2699/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2699/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2699/console
This message is automatically generated.
> The new setCombineOnceOnly shouldn't take a JobConf, since it is a method on
> JobConf
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-3599
> URL: https://issues.apache.org/jira/browse/HADOOP-3599
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.18.0
>
> Attachments: 3599.patch
>
>
> The method:
> {code}
> @Deprecated
> public void setCombineOnceOnly(JobConf conf, boolean value) {
> conf.setBoolean("mapred.combine.once", value);
> }
> {code}
> shouldn't take a JobConf.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
