[
https://issues.apache.org/jira/browse/HADOOP-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608056#action_12608056
]
Hadoop QA commented on HADOOP-3640:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12384660/hadoop-3640.patch
against trunk revision 671385.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2735/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2735/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2735/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2735/console
This message is automatically generated.
> NativeS3FsInputStream read() method for reading a single byte is incorrect
> --------------------------------------------------------------------------
>
> Key: HADOOP-3640
> URL: https://issues.apache.org/jira/browse/HADOOP-3640
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Tom White
> Assignee: Tom White
> Attachments: hadoop-3640.patch
>
>
> From Albert Chern:
> I think there may be a bug in the read() method of NativeS3InputStream, which
> looks like this:
> {code}
> public synchronized int read() throws IOException {
> int result = in.read();
> if (result > 0) {
> pos += result;
> }
> return result;
> }
> {code}
> The return value of InputStream.read() should be the next byte in the range 0
> to 255, or -1 if there are no more bytes. So shouldn't this method look
> something like this?
> {code}
> public synchronized int read() throws IOException {
> int result = in.read();
> if (result > -1) {
> pos ++;
> }
> return result;
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
