[ 
https://issues.apache.org/jira/browse/HADOOP-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608127#action_12608127
 ] 

Hadoop QA commented on HADOOP-3642:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12384682/hadoop-io-exception.patch
  against trunk revision 671563.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 443 javac compiler warnings (more 
than the trunk's current 442 warnings).

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2738/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2738/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2738/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2738/console

This message is automatically generated.

> add a HadoopIOException that can be thrown in any method that has IOException 
> on its signature
> ----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3642
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3642
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: util
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: hadoop-io-exception.patch, hadoop-io-exception.patch, 
> hadoop-io-exception.patch
>
>
> I find myself having to throw IOExceptions a lot, and create new ones -but 
> the classes signature varies from java1.5 to 1.6, and the base IOException is 
> fairly meaningless. If Hadoop added a HadoopIOException, it could be thrown 
> whenever hadoop's own code needed to create new IOExceptions, and possibly be 
> differentiated in the catch() logic. 
> The biggest disadvantage of doing this is that as IOException is built into 
> the JVM, you can be sure that the far end will be able to deserialize it 
> under RMI, without having the rest of hadoop on the classpath. This is not a 
> feature of hadoop, so should not be an issue. For those of us who do use RMI, 
> well, we'd better get our classpaths right.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to