[ 
https://issues.apache.org/jira/browse/HADOOP-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609671#action_12609671
 ] 

Doug Cutting commented on HADOOP-3479:
--------------------------------------

Overall this looks fine.  A few minor issues:
 - addResource() should call reloadConfiguration, to eliminate duplicate code
 - I can't see where the 'overlay' feature is ever used.  Should we eliminate 
it?
 - The first parameter of 'addResource' isn't needed.

The latter two are not your fault, but should probably be cleaned up anyway...


> Implement configuration items useful for Hadoop resource manager (v1)
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-3479
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3479
>             Project: Hadoop Core
>          Issue Type: New Feature
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>         Attachments: 3479.1.patch, 3479.2.patch, 3479.3.patch, 3479.patch
>
>
> HADOOP-3421 lists requirements for a new resource manager for Hadoop. 
> Implementation for these will require support for new configuration items in 
> Hadoop. This JIRA is to define such configuration, and track it's 
> implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to