[ 
https://issues.apache.org/jira/browse/HADOOP-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614801#action_12614801
 ] 

Raghu Angadi commented on HADOOP-3778:
--------------------------------------

Patch looks good. One minor change : could you wrap 'try block' around skip() 
so that it is clear where we expect the exception and it will also minimize 
changes in the patch.


> seek(long) in DFSInputStream should catch socket exception for retry later
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-3778
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3778
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.17.1
>            Reporter: LN
>            Priority: Minor
>         Attachments: HADOOP-3778.patch, HADOOP-3778.patch
>
>
> HADOOP-2346 introduced data read/write timeout. when data stream borken, 
> DFSClient will retry in read/write methods, but no such mechanism found when 
> seek(long) calling blockReader.skip(diff) (DFSClient.java #1582), will let 
> IOException throw to application.  i met NPE when using MapFile in hbase.
> i'm supposing in the seek(long) method, let done be 'false' will causing 
> retry (via 'blockEnd = -1'), a patch will attached later for review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to