[ 
https://issues.apache.org/jira/browse/HADOOP-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615486#action_12615486
 ] 

Hadoop QA commented on HADOOP-3756:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12386576/HADOOP-3756.patch
  against trunk revision 678593.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2918/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2918/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2918/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2918/console

This message is automatically generated.

> dfs.client.buffer.dir isn't used in hdfs, but it's still in 
> conf/hadoop-default.xml
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-3756
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3756
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Michael Bieniosek
>            Assignee: Raghu Angadi
>            Priority: Trivial
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3756.patch
>
>
> It looks like the usage of the config variable dfs.client.buffer.dir was 
> removed in 612903, but the variable lives on in the conf/hadoop-default.xml 
> configuration file.  If this variable really isn't used anymore, maybe we 
> should remove it from the hadoop-default.xml file?  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to