[
https://issues.apache.org/jira/browse/HADOOP-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619411#action_12619411
]
Vivek Ratan commented on HADOOP-3888:
-------------------------------------
I'd suggest that you should go ahead and provide a patch. HADOOP-3412, which
changed JobTracker.java a fair bit, is committed. Most of the scheduler work
will affect other classes, not JobTracker.
> Clean up the JobTracker code
> ----------------------------
>
> Key: HADOOP-3888
> URL: https://issues.apache.org/jira/browse/HADOOP-3888
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> My IDE flags a lot of trouble in the JobTracker code, but I dont want to mix
> those changes with any lifecycle changes. After doing that, then I'd like to
> clean up the code in JobTracker
> -move to generic types and foreach loops over Vector and iterators.
> -give all threads the correct type
> -stop using package scoped static variables to pass instance-data around
> specifically
> TASKTRACKER_EXPIRY_INTERVAL
> RETIRE_JOB_CHECK_INTERVAL
> RETIRE_JOB_INTERVAL
> -fix up all the javadoc warnings
> -remove the needless this. references on lots of local variables
> -replace the log + stringifyException with log(text,exception).
> Its only an hour or so of work, and would improve the code maintainability,
> but it would make merging existing code harder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
