[
https://issues.apache.org/jira/browse/HADOOP-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620334#action_12620334
]
Hadoop QA commented on HADOOP-3773:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12386205/HADOOP-3773-trunk.patch
against trunk revision 682978.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3019/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3019/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3019/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3019/console
This message is automatically generated.
> Setting the conf twice in Pipes Submitter
> -----------------------------------------
>
> Key: HADOOP-3773
> URL: https://issues.apache.org/jira/browse/HADOOP-3773
> Project: Hadoop Core
> Issue Type: Bug
> Components: pipes
> Reporter: Koji Noguchi
> Assignee: Koji Noguchi
> Priority: Trivial
> Attachments: HADOOP-3773-trunk.patch
>
>
> In Submitter.java,
> {noformat}
> 228 setIfUnset(conf, "mapred.output.key.class", textClassname);
> 229 setIfUnset(conf, "mapred.output.value.class", textClassname);
> 230 setIfUnset(conf, "mapred.output.key.class", textClassname);
> 231 setIfUnset(conf, "mapred.output.value.class", textClassname);
> {noformat}
> I think this meant to set mapred.*map*output.{key,value}.class instead of
> setting the same conf twice.
> (It doesn't really matter since mapred.mapoutput.{key,value}.class defaults
> to mapred.output.{key,value}.class.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
