[
https://issues.apache.org/jira/browse/HADOOP-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620857#action_12620857
]
Devaraj Das commented on HADOOP-3150:
-------------------------------------
I went through parts of the patch that affects the core protocols. Some
comments:
1) The Umbilical protocol doesn't need to have the commitError method. The
tasktracker can just kill the task for which the JT returns "discard output"
leaving the cleanup of this task's output to the JT (cleanupJob).
2) I don't understand why there is a sendLastUpdate before sendDone.
3) The check for whether to commit needs to just check the existence of the
temp output directory. It doesn't need to check the contents of that (since
these directories are now created only on demand) and once they exist we can
assume that they do require a commit.
4) The TIP should reset the taskId that got marked as "commit-pending" to
empty. This is because the TT could be "lost" after the task was marked as
commit-pending in the JT.
5) Indentation has to be fixed in JobInProgress.java
6) Overall, some comments are redundant.
> Move task file promotion into the task
> --------------------------------------
>
> Key: HADOOP-3150
> URL: https://issues.apache.org/jira/browse/HADOOP-3150
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: 3150.patch, patch-3150.txt, patch-3150.txt,
> patch-3150.txt, patch-3150.txt, patch-3150.txt, patch-3150.txt,
> patch-3150.txt, patch-3150.txt
>
>
> We need to move the task file promotion from the JobTracker to the Task and
> move it down into the output format.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
