[
https://issues.apache.org/jira/browse/HADOOP-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620934#action_12620934
]
Hadoop QA commented on HADOOP-3506:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12387808/hadoop-3506.patch
against trunk revision 683671.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3038/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3038/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3038/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3038/console
This message is automatically generated.
> Occasional NPE in Jets3tFileSystemStore
> ---------------------------------------
>
> Key: HADOOP-3506
> URL: https://issues.apache.org/jira/browse/HADOOP-3506
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs/s3
> Affects Versions: 0.17.0
> Reporter: Robert
> Assignee: Tom White
> Attachments: hadoop-3506.patch
>
>
> In extraordinary circumstances (eg. S3 outages), calling S3FileSystem
> functions will throw NullPointerExceptions when trying to read from the
> filesystem. I've traced this down to calls to Jets3tFileSystemStore.get().
> Both get() functions catch an S3ServiceException, and check its error code
> using a string comparison. However, the underlying libs3t library will
> sometimes produce an exception with a null error code string. This results in
> an NPE that propagates all the way to the S3FileSystem, and to the caller.
> To fix this, Jets3tFileSystemStore lines 196 and 212 should be changed from:
> bq. if (e.getS3ErrorCode().equals("NoSuchKey")) {
> to:
> bq. if ("NoSuchKey".equals(e.getS3ErrorCode())) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
