[ 
https://issues.apache.org/jira/browse/HADOOP-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated HADOOP-3951:
----------------------------------

    Attachment: 3951-1.patch

bq. It would be great to make all LOG variables final. In general, all static 
variables should be final.

Agreed, but this is OK for now.

bq. We could use LogFactory.getLog(XXX.class) instead of 
LogFactory.getLog(XXX.class.getClassName())

Sure. It's the 
[same|http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java?view=annotate]
 either way, but using the class is more readable.

> The package name used in FSNamesystem is incorrect
> --------------------------------------------------
>
>                 Key: HADOOP-3951
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3951
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Chris Douglas
>         Attachments: 3951-0.patch, 3951-1.patch, 3951_20080813.patch
>
>
> FSNamesystem is in org.apache.hadoop.hdfs.server.namenode package.  The name 
> org.apache.hadoop.fs.FSNamesystem used in the codes is incorrect.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to