[
https://issues.apache.org/jira/browse/HADOOP-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625583#action_12625583
]
Chris Douglas commented on HADOOP-3789:
---------------------------------------
Just a few nits:
* Instead of {{stderrStatus.delete(0, stderrStatus.length())}},
{{stderrStatus.setLength(0)}} should do the same thing. The former should just
make a call to System.arraycopy- which won't do anything- but the latter is a
little more readable.
* Instead of appending to the buffer and copying over the excess,
stderrStatusLimit might be enforced more strictly by doing the length check and
delete before the append of lineStr
* It looks like the buffer size config gets thrown away, instead of being
assigned to stderrStatusLimit:
{noformat}
@@ -122,6 +122,7 @@
fs_ = FileSystem.get(job_);
nonZeroExitIsFailure_ =
job_.getBoolean("stream.non.zero.exit.is.failure", true);
+ job_.getInt("stream.stderr.capture.limit", 2048);
doPipe_ = getDoPipe();
if (!doPipe_) return;
{noformat}
> Include more detail in the exception message when a streaming task fails
> ------------------------------------------------------------------------
>
> Key: HADOOP-3789
> URL: https://issues.apache.org/jira/browse/HADOOP-3789
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-3789-v2.patch, hadoop-3789.patch
>
>
> When debugging streaming programs, it would be useful to have the last few
> lines from stderr in the exception message (which is shown in the task's
> status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
