[
https://issues.apache.org/jira/browse/HADOOP-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625676#action_12625676
]
Hadoop QA commented on HADOOP-3965:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12388786/DataBlockScanner.patch
against trunk revision 688960.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3105/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3105/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3105/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3105/console
This message is automatically generated.
> Make DataBlockScanner package private
> -------------------------------------
>
> Key: HADOOP-3965
> URL: https://issues.apache.org/jira/browse/HADOOP-3965
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: DataBlockScanner.patch
>
>
> {{DataBlockScanner}} should be a package private class rather than public.
> "public" can be removed if we move {{TestInterDatanodeProtocol}} into
> {{org.apache.hadoop.hdfs.server.datanode}} package.
> This will require to make some changes to the import section.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
