[
https://issues.apache.org/jira/browse/HADOOP-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626829#action_12626829
]
Konstantin Shvachko commented on HADOOP-3948:
---------------------------------------------
- I think classes StorageDirType and DirIterator need JavaDoc explaining what
they are for.
It would be good to indicate that DirIterator can be dirType specific or
iterate through all.
- StorageDirectory.setStorageDirType() is not used anywhere. Let's not
introduce public methods if they do not have immediate usage.
- In FSEditLog.getEditLogSize() it is better to replace {{idx <
getNumStorageDirs()}} by {{idx < editStreams.size()}}
- I have indentation problems looks like you have tabs in the new code. You can
try setting tab size to 2 and you will see where indentation is not right.
- In case of FSEditLog.rollEditLog() you call it.remove() to remove
StorageDirectory in which a file cannot be created, but never
incrementCheckpointTime().
Can that be a problem?
- FSImage does need to import StorageDirectory, List and AbstractList.
- FSImage.getFileNames() should return {{List<File>}} rather than {{File []}}.
We should file a separate jira for that. Not related to the patch.
> Separate Namenodes edits and fsimage
> -------------------------------------
>
> Key: HADOOP-3948
> URL: https://issues.apache.org/jira/browse/HADOOP-3948
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Lohit Vijayarenu
> Attachments: HADOOP-3948.patch, HADOOP-3948.patch, HADOOP-3948.patch,
> HADOOP-3948.patch, hadoop-core-trunk.patch, hadoop-core-trunk.patch,
> hadoop-core-trunk.patch
>
>
> NameNode's _edits_ and _fsimage_ should be separated with an option of having
> them in their own separate directories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
