[ 
https://issues.apache.org/jira/browse/HADOOP-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626865#action_12626865
 ] 

Hemanth Yamijala commented on HADOOP-3970:
------------------------------------------

Amar and I thought about this a bit. Groups also have internal and display 
names, apparently. Since space is a character that may be more common in 
display names (we have examples in the current list of counters), it may be 
better to do something like:
{code}
{(gi1)(gd1){(ci1)(cd1)(v1)}}
{code}. 

Real example: 
{code}
{(org.apache.hadoop.mapred.Task$FileSystemCounter)(File 
Systems){(HDFS_READ)(HDFS bytes read)(1020634)}}
{code} 
as opposed to 
{code}
{org.apache.hadoop.mapred.Task$FileSystemCounter File\ Systems {HDFS_READ HDFS\ 
bytes\ read 1020634}}
{code}

IMHO, the first is a bit more readable, and clear where the tokens are ending. 
Comments ?

> Counters written to the job history cannot be recovered back
> ------------------------------------------------------------
>
>                 Key: HADOOP-3970
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3970
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>         Attachments: HADOOP-3970-v1.patch
>
>
> Counters that are written to the JobHistory are stringified using 
> {{Counters.makeCompactString()}}. The format in which this api converts the 
> counter into a string is _groupname.countername:value_. The problem is that 
> _groupname_ and _countername_ can contain a '.' and hence recovering the 
> counter becomes difficult. Since JobHistory can be used for various purposes, 
> reconstructing the counter object back might be useful. One such usecase is 
> HADOOP-3245. There should be some way to recover the counter object back from 
> its string representation and also to keep the string version readable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to