[
https://issues.apache.org/jira/browse/HADOOP-3992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628114#action_12628114
]
Tsz Wo (Nicholas), SZE commented on HADOOP-3992:
------------------------------------------------
Below are more review comments:
- Change comments to javadoc.
- Print generic options in usage
StructureGenerator.java
- r.nextInt(maxWidth-minWidth) should be r.nextInt(maxWidth-minWidth+1).
- Should we use IllegalArgumentException, instead of NumberFormatException?
LoadGenerator.java
- "-seed" here may not be useful since the randomness depends on the execution
order of the threads.
- Check individual range for readPr, writePr, maxDelayBetweenOps
- In javadoc, we should mention that the unit of maxDelayBetweenOps is
milliseconds.
> Synthetic Load Generator for NameNode testing
> ---------------------------------------------
>
> Key: HADOOP-3992
> URL: https://issues.apache.org/jira/browse/HADOOP-3992
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs
> Reporter: Robert Chansler
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: loadGenerator.patch, LoadGeneratorUserGuide.pdf
>
>
> For performance and correctness testing. The goal is to faithfully simulate
> the load of a 5000-node cluster with a (comparatively) tiny number of nodes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
