[
https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628189#action_12628189
]
Konstantin Shvachko commented on HADOOP-4054:
---------------------------------------------
This looks right.
But then you can also remove code that removes lease after
{{unprotectedDelete()}} in line 673: in the OP_DELETE case.
And then variable {{old}} can be removed as it is not used.
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637:
> fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very
> annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
