[ https://issues.apache.org/jira/browse/HADOOP-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628669#action_12628669 ]
Hadoop QA commented on HADOOP-3722: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12389435/jobconfoptions_v2.patch against trunk revision 692409. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3189/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3189/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3189/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3189/console This message is automatically generated. > Provide a unified way to pass jobconf options from bin/hadoop > ------------------------------------------------------------- > > Key: HADOOP-3722 > URL: https://issues.apache.org/jira/browse/HADOOP-3722 > Project: Hadoop Core > Issue Type: New Feature > Components: conf > Affects Versions: 0.19.0 > Reporter: Matei Zaharia > Assignee: Enis Soztutar > Priority: Minor > Fix For: 0.19.0 > > Attachments: HADOOP-3722.patch, jobconfoptions_v1.patch, > jobconfoptions_v2.patch > > > Often when running a job it is useful to override some jobconf parameters > from jobconf.xml for that particular job - for example, setting the job > priority, setting the number of reduce tasks, setting the HDFS replication > level, etc. Currently the Hadoop examples, streaming, pipes, etc take these > extra jobconf parameters in different was: the examples in > hadoop-examples.jar use -Dkey=value, streaming uses -jobconf key=value, and > pipes uses -jobconf key1=value1,key2=value2,etc. Things would be simpler if > bin/hadoop could take the jobconf parameters itself, so that you could run > for example bin/hadoop -Dkey=value jar [whatever] as well as bin/hadoop > -Dkey=value pipes [whatever]. This is especially useful when an organization > needs to require users to use a particular property, e.g. the name of a queue > to use for scheduling in HADOOP-3445. Otherwise, users may confuse one way of > passing parameters with another and may not notice that they forgot to > include certain properties. > I propose adding support in bin/hadoop for jobconf options to be specified > with -C key=value. This would have the effect of setting > hadoop.jobconf.key=value in Java's system properties. The Configuration class > would then be modified to read any system properties that begin with > hadoop.jobconf and override the values in hadoop-site.xml. > I can write a patch for this pretty quickly if the design is sound. If > there's a better way of specifying jobconf parameters uniformly across Hadoop > commands, let me know. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.