[ 
https://issues.apache.org/jira/browse/HADOOP-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628969#action_12628969
 ] 

Craig Macdonald commented on HADOOP-3264:
-----------------------------------------

Pete,

This looks very good. I have a few minor comments:
 * it appears that some of the changes from HADOOP-3963 have bled into your 
patch. Can you recreate the patch once HADOOP-3963 is committed?
 *  src/c++/libhdfs/hdfs_test.c - I think that some of my work in progress 
changes are missing from your patch.
 * We need to add some test cases.  I guess the test run will depend on the 
user running the test - can we test chmod if there are no other users to chmod 
a file to?

C

> libhdfs does not provide permissions in API
> -------------------------------------------
>
>                 Key: HADOOP-3264
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3264
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.16.2
>            Reporter: Craig Macdonald
>         Attachments: HADOOP-3264.2.txt, libhdfs_permissions.v1.patch, 
> libhdfs_permissions.v2.patch
>
>
> There is no support in libhdfs methods for obtaining or setting the 
> permissions, owner or group-owner of files in hdfs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to