[ 
https://issues.apache.org/jira/browse/HADOOP-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629175#action_12629175
 ] 

Hadoop QA commented on HADOOP-4100:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12389658/patch-4100.txt
  against trunk revision 693048.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3206/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3206/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3206/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3206/console

This message is automatically generated.

> Scheduler.assignTasks should not be dealing with cleanupTask
> ------------------------------------------------------------
>
>                 Key: HADOOP-4100
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4100
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Devaraj Das
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.19.0
>
>         Attachments: patch-4100.txt
>
>
> HADOOP-3150 introduced the notion of a cleanupTask. The implementation of the 
> scheduling of the cleanupTask is such that the schedulers have to be aware of 
> the cleanupTask. It would be very nice if schedulers didn't have to be aware 
> of this special task. There is a discussion thread - 
> https://issues.apache.org/jira/browse/HADOOP-3150?focusedCommentId=12628635#action_12628635

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to