[ 
https://issues.apache.org/jira/browse/HADOOP-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629391#action_12629391
 ] 

Amar Kamat commented on HADOOP-4112:
------------------------------------

Few comments

_JobHistory  :_ 
1) The comment for {{CleanupAttempt}} class needs to be changed.
2) {{logFailed()}} and {{logKilled()}} differ in one string. I assume you have 
done just to keep the code consistent. Someday we should collapse both the 
api's into something like {{logComplete()}}. There is a lot of 
duplicate/redundant code.

_JobInProgress :_ 
1) Why is job-failed log removed? Redundancy?
2) I think there are some diffs because of formatting changes

Note that I have just checked {{JobHistory.java}} and {{JobInProgress.java}}.

> Got ArrayOutOfBound exception while analyzing the job history
> -------------------------------------------------------------
>
>                 Key: HADOOP-4112
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4112
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amar Kamat
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.19.0
>
>         Attachments: patch-4112.txt
>
>
> HADOOP-3150 introduced 2 new type of tasks called the cleanup tasks. These 
> are logged to history either as map tasks or reduce tasks. The number of 
> maps/reducers is also logged to history. Since the number of maps will be 
> less than the total number of map tasks logged to history (actual num maps + 
> cleanup tasks), I think thats the reason for this exception. The important 
> question is to investigate the effect of HADOOP-3150 on job history and code 
> related to it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to