[
https://issues.apache.org/jira/browse/HADOOP-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629710#action_12629710
]
Hadoop QA commented on HADOOP-4141:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389792/TestScriptBasedMapping.java
against trunk revision 693705.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3226/console
This message is automatically generated.
> ScriptBasedMapping has infinite loop with invalid jobconf parameter
> -------------------------------------------------------------------
>
> Key: HADOOP-4141
> URL: https://issues.apache.org/jira/browse/HADOOP-4141
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Aaron Kimball
> Priority: Minor
> Attachments: scriptMap.patch, TestScriptBasedMapping.java
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> A few bugs in ScriptBasedTopology:
> 1) topology.script.number.args is not validated; if this is <= 0, the
> runResolveCommand() method will run its outer loop an infinite number of
> times.
> 2) CachedDNSToSwitchMapping assumes that if a List is returned, it has the
> same cardinality as the number of names. ScriptBasedMapping should return
> 'null' instead of a mis-sized list on error
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
