[ 
https://issues.apache.org/jira/browse/HADOOP-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629796#action_12629796
 ] 

Devaraj Das commented on HADOOP-3245:
-------------------------------------

Overall it looks good to me..
A few comments:
1) Make the check for status as RUNNING explicitly in 
JobTracker.RecoveryManager.JobRecoveryListener.checkAndInit
2) Rename the variable 'cause' in JobHistory.Task.LogFailed failedDueToAttempt
3) Call JobInProgressListener.jobUpdated after the job recovery
4) ReduceTask need not check for copied maps upon restart as copyOutput already 
does it.

Overall, this patch should be tested thoroughly under various conditions like 
map partially complete, reduces partially complete, the values for the counters 
being consistent across restarts, etc.

> Provide ability to persist running jobs (extend HADOOP-1876)
> ------------------------------------------------------------
>
>                 Key: HADOOP-3245
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3245
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: mapred
>            Reporter: Devaraj Das
>            Assignee: Amar Kamat
>         Attachments: HADOOP-3245-v2.5.patch, HADOOP-3245-v2.6.5.patch, 
> HADOOP-3245-v2.6.9.patch, HADOOP-3245-v4.1.patch, HADOOP-3245-v5.13.patch, 
> HADOOP-3245-v5.14.patch, HADOOP-3245-v5.26.patch, 
> HADOOP-3245-v5.30-nolog.patch, HADOOP-3245-v5.31.3-nolog.patch, 
> HADOOP-3245-v5.33.1.patch, HADOOP-3245-v5.35.3-no-log.patch
>
>
> This could probably extend the work done in HADOOP-1876. This feature can be 
> applied for things like jobs being able to survive jobtracker restarts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to