[
https://issues.apache.org/jira/browse/HADOOP-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630094#action_12630094
]
Vinod K V commented on HADOOP-4145:
-----------------------------------
Very minor comments, mostly related to logging.
- is_valid_account() documentation string should read as
"<work-dir>/verify-account" or "<install-dir>/bin/verify-account" instead of
"<install-dir>/verify-account". Actual usage is correct.
- Would be clear if, while logging, the output from the verify-account script
file is marked, for e.g. prepended with "verify-account output : ".
- Irrespective of the return code
-- we should just log the output of the script at debug level.
-- we should conclude the operation by a *info* log statement - HOD
verify-account succeeded / failed with error code <errCode>, with script output
<scriptOut>
- When verify-account returns a non-zero error code, we log "err msg from
script: %s' % errMsg" - this should be "output msg from script". This msg will
go away if we do what the immediately above point describes.
Other than these, +1 for the patch, it works as described.
> [HOD] Support an accounting plugin script for HOD
> -------------------------------------------------
>
> Key: HADOOP-4145
> URL: https://issues.apache.org/jira/browse/HADOOP-4145
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hod
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.18.1, 0.19.0
>
> Attachments: HADOOP-4145.patch
>
>
> Production environments have accounting packages to track usage of a cluster.
> HOD should provide a mechanism to plug-in an accounting related script that
> can be used to verify if the user is using a valid account or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
