[ 
https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630162#action_12630162
 ] 

Enis Soztutar commented on HADOOP-3975:
---------------------------------------

I think, test-patch should be able to run in an environment where svn stat != 
"". Specifically a requirement arises when we are adding a new lib, and to run 
the audit checks we put the lib in trunk. 

I think we should either use [`$SVN stat | grep -v "?"` != "" ], or better 
switch to a binary diff-patch process. 


> test-patch can report the modifications found in the workspace along with the 
> error message
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3975
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3975
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: test
>            Reporter: Hemanth Yamijala
>            Assignee: Ramya R
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-3975-v1.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, 
> it errors out by saying "ERROR: can't run in a workspace that contains 
> modifications". It appears this is printed when svn stat command returns a 
> non-empty output. It would be helpful to report this output, so that 
> developers can be alerted to what modifications are causing this error. 
> Sometimes these modifications may not be because of a direct code change 
> they've done, but remnants of an incorrect cleanup of the last build, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to