[
https://issues.apache.org/jira/browse/HADOOP-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631631#action_12631631
]
Hadoop QA commented on HADOOP-3623:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390232/3623_20080916.patch
against trunk revision 696112.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3279/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3279/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3279/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3279/console
This message is automatically generated.
> LeaseManager needs refactoring.
> -------------------------------
>
> Key: HADOOP-3623
> URL: https://issues.apache.org/jira/browse/HADOOP-3623
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Konstantin Shvachko
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.19.0
>
> Attachments: 3623_20080915.patch, 3623_20080916.patch
>
>
> LeaseManager is a name-node class, which contains (after HADOOP-3310) static
> members and methods serving data-node code.
> I think we should keep the code related to different components of hdfs
> separatly, especially in view of the upcoming changes in hdfs packaging
> HADOOP-2884.
> The separation may be achieved by introducing a new class
> DatanodeLeaseManager and then moving all related methods into the new class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
