[
https://issues.apache.org/jira/browse/HADOOP-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631778#action_12631778
]
Ashish Thusoo commented on HADOOP-4085:
---------------------------------------
Lets cleanup the System.outs that we have (I presume that this debugging code
that did not get removed when you submitted the patch).
Also can you comment on the second one - is that code ok?
Inline Comments:
ql/src/java/org/apache/hadoop/hive/ql/exec/CompositeHiveObject.java:92: We
should avoid System.outs - use logging instead.
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java:143: Don't we have to
look at all the sort columns here?
ql/src/java/org/apache/hadoop/hive/ql/exec/ExtractOperator.java:40: No
System.out !!
ql/src/java/org/apache/hadoop/hive/ql/exec/LabeledCompositeHiveObject.java:40:
No System.out !!
Thanks,
Ashish
> internationalization support and sort order (ascedning/descending) support in
> create table
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-4085
> URL: https://issues.apache.org/jira/browse/HADOOP-4085
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch1, patch2
>
>
> User cannot specify utf8 strings in the query, both for selection and
> filtering. Mysql syntax should be followed:
> select _utf8 'string' from <TableName>
> select <selectExpr> from <TableName> where col = _utf8 0x<HexValue>
> To start with, utf8 strings should be supported. Support for other character
> sets can be added in the future on demand.
> The identifiers (table name/column name etc.) cannot be utf8 strings, it is
> only for the data values.
> Although, in create table, the user has the option of specifying sorted
> columns, he does not have the option of specifying whether they are ascending
> or descending.
> Create Table syntax should be enhanced to support that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
