[ 
https://issues.apache.org/jira/browse/HADOOP-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632086#action_12632086
 ] 

Amareshwari Sriramadasu commented on HADOOP-3924:
-------------------------------------------------

Minor comments:
1. In terminateJob method, two if-else checks can be collapsed into one if-else.
2. There are lines exceeding 80 characters in JobTracker.java and 
JobHistory.java. And JobClient has unnecessary java.util.Date and DateFormat 
imports added.

Otherthan that, the patch looks good.

> Add a 'Killed' job status
> -------------------------
>
>                 Key: HADOOP-3924
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3924
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: mapred
>         Environment: all
>            Reporter: Alejandro Abdelnur
>            Assignee: Subramaniam Krishnan
>            Priority: Critical
>         Attachments: patch-3924_v1.txt, patch-3924_v2.txt, patch-3924_v3.txt
>
>
> It is not possible, via APIs, to know if a job has been killed, only that has 
> not been successful.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to