[ 
https://issues.apache.org/jira/browse/HADOOP-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated HADOOP-3894:
----------------------------------

    Status: Open  (was: Patch Available)

* This still adds the String parameter to processDatanodeError that is never 
referenced in the body of that method
* Does this test time out often? Is there a contract that this should take less 
than a minute to run? I completely sympathize with the impulse to retain the 
information that ant discards and something is probably amiss if this test hits 
the timeout, but if we're going to fail tests because they violate limits then 
those limits should be based on something quantifiable and intrinsic to the 
model we're testing.

If the purpose of this issue is to use log4j instead of System.err to print the 
error in DFSClient::close, then this should probably be limited to changing 
that line and updating the unit test.

> DFSClient chould log errors better, and provide better diagnostics
> ------------------------------------------------------------------
>
>                 Key: HADOOP-3894
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3894
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Trivial
>             Fix For: 0.19.0
>
>         Attachments: hadoop-3894.patch, hadoop-3894.patch, hadoop-3894.patch
>
>
> In my test runs I see a stack trace from DFSClient, because it isn't logging 
> through the log APIs in its close() method. It should use the logger, for 
> better error reporting

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to