[
https://issues.apache.org/jira/browse/HADOOP-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suresh Srinivas updated HADOOP-4210:
------------------------------------
Attachment: HADOOP-4210.patch
Incorporating code review comments from Chris:
1. Use base class equals method in the sub classes
2. Class ID should not be instantiated. Hence making it abstract and removing
the unused static methods that were instantiating the class ID.
> Findbugs warnings are printed related to equals implementation of several
> classes
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-4210
> URL: https://issues.apache.org/jira/browse/HADOOP-4210
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.19.0
>
> Attachments: HADOOP-4210.patch, HADOOP4210.patch
>
>
> During compilation - findbugs generates several warnings that indicates bugs
> in the implementation of equals method. One of the example of this report is:
> Bug type EQ_GETCLASS_AND_CLASS_CONSTANT (click for details)
> In class org.apache.hadoop.mapred.ID
> In method org.apache.hadoop.mapred.ID.equals(Object)
> At ID.java:[line 66]
> Value doesn't work for subtypes
> This class has an equals method that will be broken if it is inherited by
> subclasses. It compares a class literal with the class of the argument (e.g.,
> in class Foo it might check if Foo.class == o.getClass()). It is better to
> check if this.getClass() == o.getClass().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
