[ 
https://issues.apache.org/jira/browse/HADOOP-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632868#action_12632868
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-4227:
------------------------------------------------

{noformat}
     [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no tests are needed for 
this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.

     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
{noformat}

No new tests added since there is essentially no code changes.

> Remove the deprecated, unused class ShellCommand.
> -------------------------------------------------
>
>                 Key: HADOOP-4227
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4227
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 4227_20080919.patch
>
>
> org.apache.hadoop.fs.ShellCommand was deprecated in 0.16 and is unused in 
> current trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to