[ https://issues.apache.org/jira/browse/HADOOP-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632907#action_12632907 ]
Hadoop QA commented on HADOOP-4226: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12390539/LineReader.java.patch against trunk revision 697306. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3338/console This message is automatically generated. > LineRecordReader::readLine cleanup > ---------------------------------- > > Key: HADOOP-4226 > URL: https://issues.apache.org/jira/browse/HADOOP-4226 > Project: Hadoop Core > Issue Type: Improvement > Components: mapred > Affects Versions: 0.19.0 > Reporter: Yuri Pradkin > Priority: Minor > Attachments: LineReader.java.patch > > > I've been looking at HADOOP-4010 and realized that readLine is pretty > convoluted. I changed the implementation which made it hopefully a little > easier to read/validate/understand. > I've had some problems testing it locally, so I'll submit it for Hudson to > test. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.