[ https://issues.apache.org/jira/browse/HADOOP-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-4204: ------------------------------------ Attachment: HADOOP-4204.patch Thanks for the comments. I have made the suggested changes. I ran the unit tests. All the tests passed except org.apache.hadoop.mapred.jobcontrol.TestLocalJobControl. That test fails without this patch also. So it is an unrelated problem. Without the patch findbugs warnings is 225. With this patch the number of findbugs warnings is 201. Here is the result of ant test-patch [exec] +1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. > Fix warnings generated by FindBugs > ---------------------------------- > > Key: HADOOP-4204 > URL: https://issues.apache.org/jira/browse/HADOOP-4204 > Project: Hadoop Core > Issue Type: Bug > Environment: This is compile time issue > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Fix For: 0.19.0 > > Attachments: HADOOP-4204.patch, HADOOP-4204.patch > > > There are several warnings currently printed by findbugs. These need to be > addressed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.