[
https://issues.apache.org/jira/browse/HADOOP-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634278#action_12634278
]
Yuri Pradkin commented on HADOOP-4226:
--------------------------------------
OK, let me respond to Hudson:
1. Tests: since this is not new code, I don't feel obligated to provide more
tests. There already exist tests for TextInputFormat that are already checking
this code; these tests pass.
2. Two failed tests: I've re-run these tests on my box, they pass (except
TestLeaseRecovery2 throws exception closing an already closed file, but it
still passes) on my system. What's up with that? If you could point me to a
"clean" revision, I'll be happy to generate a patch against that. Otherwise I
think we're OK here.
I might make one more little change to the code to make it a little cleaner,
but otherwise I think the patch is ready. I urge commiters to look at it and
let me know what they think. I'd hate my time to be wasted, so please comment.
> LineReader::readLine cleanup
> ----------------------------
>
> Key: HADOOP-4226
> URL: https://issues.apache.org/jira/browse/HADOOP-4226
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Yuri Pradkin
> Assignee: Yuri Pradkin
> Priority: Minor
> Attachments: HADOOP-4226.patch, HADOOP-4226.patch
>
>
> I've been looking at HADOOP-4010 and realized that readLine is pretty
> convoluted. I changed the implementation which made it hopefully a little
> easier to read/validate/understand.
> I've had some problems testing it locally, so I'll submit it for Hudson to
> test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
