[ 
https://issues.apache.org/jira/browse/HADOOP-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634526#action_12634526
 ] 

Ning Li commented on HADOOP-4271:
---------------------------------

> > You really don't need change ChecksumFileSystem at all. You don't need to 
> > test with verifyChecksum off I think. It will make the patch much simpler.

> Before the patch, the default of verifyChecksum in FSInputChecker is false. I 
> made the change in order to test with verifyChecksum being true.

Should the default of verifyChecksum be true? If so and if we only test with 
verifyChecksum being true, then yes, the patch can be much simpler.

> Bug in FSInputChecker makes it possible to read from an invalid buffer
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-4271
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4271
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.16.0
>            Reporter: Ning Li
>            Assignee: Ning Li
>            Priority: Blocker
>             Fix For: 0.18.2, 0.19.0, 0.20.0
>
>         Attachments: .data_testFSInputChecker.crc, data_testFSInputChecker, 
> hadoop-4271.patch, hadoop-4271.patch
>
>
> Bug in FSInputChecker makes it possible to read from an invalid buffer. The 
> buffer in FSInputChecker becomes invalid when readChecksumChunk is used to 
> read a chunk to a user buffer directly. Currently, it's not marked as invalid 
> in this case and may be read subsequently.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to