[
https://issues.apache.org/jira/browse/HADOOP-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635029#action_12635029
]
Konstantin Shvachko commented on HADOOP-3614:
---------------------------------------------
I think assert is right here. It means that {{findBlockFile()}} method should
find a file containing the block by its block id no matter what its generation
stamp is, and therefore findBlockFile should always be called with the
generation stamp == WILDCARD_STAMP.
What is incorrect here is the api. {{findBlockFile(long blockID)}} should take
block ID as a parameter and then the assert can be removed.
A comment stating exactly what the method does would be extremely helpful.
> TestLeaseRecovery fails when run with assertions enabled.
> ---------------------------------------------------------
>
> Key: HADOOP-3614
> URL: https://issues.apache.org/jira/browse/HADOOP-3614
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Konstantin Shvachko
> Fix For: 0.19.0
>
>
> I used -ea jvm options to run the test, and it fails in
> FSDataset.findBlockFile(Block) on
> {code}
> assert b.generationStamp == GenerationStamp.WILDCARD_STAMP;
> {code}
> Without asserts on the test passes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
