[ 
https://issues.apache.org/jira/browse/HADOOP-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated HADOOP-4261:
--------------------------------------------

    Attachment: patch-4261.txt

Modified TestJobTrackerRestart to test setuptask Reports. 
Modified ObtainSetup/CleanupTask to use addRunningTaskToTIP()
Changed canLaunchSetupTask's implementation as suggested by Amar

bq. It would make more sense to call the job run-state as SETUP when 
logInited() is invoked
This would not be in consistent with JobStatus. Adding SETUP as JobStatus is 
not necessary.

bq.I dont see any code that deals with setup task in job-recovery i.e 
recovery-manager
There is no specific change required. Change in checkAndInit method will do.



> Jobs failing in the init stage will never cleanup
> -------------------------------------------------
>
>                 Key: HADOOP-4261
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4261
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: patch-4261.txt, patch-4261.txt
>
>
> Pre HADOOP-3150, if the job fails in the init stage, {{job.kill()}} was 
> called. This used to make sure that the job was cleaned up w.r.t 
> - staus set to KILLED/FAILED
> - job files from the system dir are deleted
> - closing of job history files
> - making jobtracker aware of this through {{jobTracker.finalizeJob()}}
> - cleaning up the data structures via {{JobInProgress.garbageCollect()}}
> Now if the job fails in the init stage, {{job.fail()}} is called which doesnt 
> do the cleanup. HADOOP-3150 introduces cleanup tasks which are launched once 
> the job completes i.e killed/failed/succeeded.  Jobtracker will never 
> consider this job for scheduling as the job will be in the {{PREP}} state 
> forever.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to