[ 
https://issues.apache.org/jira/browse/HADOOP-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635553#action_12635553
 ] 

Hairong Kuang commented on HADOOP-4281:
---------------------------------------

The patch looks good. I have two minor comments:
1. In DFSAdmin.java, it would be nice to switch the following two statements
+ long presentCapacity = ds.getDfsUsed() + ds.getRemaining();
+ long used = ds.getDfsUsed();
to be
      long used = ds.getDfsUsed();
      long presentCapacity = used + ds.getRemaining();
 2. In DatanodeInfo.toString, it would be nice to use dfs.getDfsUsedPercent() 
to calculate the %Used.

I think Suresh meant to mark this issue as a block to 0.19. I will mark it for 
him.


> Capacity reported in some of the commands is not consistent with the Web UI 
> reported data
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4281
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4281
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.19.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-4281.patch
>
>
> Changes submitted for 2816 changed the Web UI to report the capacity 
> differently. The same changes need to be applied to commands that show 
> namenode and datanode capacities

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to