[
https://issues.apache.org/jira/browse/HADOOP-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636388#action_12636388
]
Doug Cutting commented on HADOOP-4328:
--------------------------------------
> We should mark the convenient methods final.
This may not be a line we can maintain. Folks may reasonably want to override
some of these methods, and we will be asked to make some of them non-final.
Long-term we may be able to keep most of them final, but not all.
> the create(...) method has 10 different signatures.
That's bloat we should get rid of. I can see having three, perhaps, but 10 is
way too many. We should see which are commonly used, then deprecate the rest.
Perhaps we should have a FileCreateOptions class that's passed instead of
having so many parameters? We should file a separate issue about this. Should
I, or will you?
> Some convenient methods in the FileSystem API should be final.
> --------------------------------------------------------------
>
> Key: HADOOP-4328
> URL: https://issues.apache.org/jira/browse/HADOOP-4328
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
>
> In FileSystem, some methods are overloaded with different parameter list. We
> should mark the convenient methods final.
> For example, the create(...) method has 10 different signatures. Subclasses
> of FileSystem should only override the one with the most number or parameters
> but not the others. We should mark all the other 9 create(...) final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
